Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update CRD and related code to enable type field #1779

Merged
merged 7 commits into from
Sep 10, 2024
Merged

chore: update CRD and related code to enable type field #1779

merged 7 commits into from
Sep 10, 2024

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Sep 5, 2024 •
edited
Loading

Description

What this PR does / why we need it:

updated CRDs and related code; enabled type field

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1285

Type of change

Please delete options that are not relevant.

  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...controllers/clusterresource/verifier_controller.go 90.24% <100.00%> (+10.24%) ⬆️
...ntrollers/namespaceresource/verifier_controller.go 90.00% <100.00%> (+10.00%) ⬆️
pkg/controllers/utils/verifier.go 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

binbin-li
binbin-li reviewed Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update the title with more information?

api/v1beta1/namespacedverifier_types.go Show resolved Hide resolved
api/v1beta1/verifier_types.go Outdated Show resolved Hide resolved
pkg/controllers/clusterresource/verifier_controller.go Outdated Show resolved Hide resolved
pkg/controllers/namespaceresource/verifier_controller.go Outdated Show resolved Hide resolved
@junczhu junczhu changed the title chore: crd type field chore: update CRD and related code to enable type field Sep 8, 2024
binbin-li
binbin-li reviewed Sep 9, 2024
View reviewed changes
config/rbac/role.yaml Outdated Show resolved Hide resolved
@junczhu junczhu marked this pull request as ready for review September 9, 2024 05:35
binbin-li
binbin-li reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, lgtm overall

api/unversioned/verifier_types.go Outdated Show resolved Hide resolved
pkg/controllers/utils/verifier.go Outdated Show resolved Hide resolved
@junczhu junczhu enabled auto-merge (squash) September 10, 2024 07:59
@junczhu junczhu merged commit 7657a3f into ratify-project:dev Sep 10, 2024
19 checks passed
akashsinghal pushed a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
@junczhu @binbin-li @akashsinghal
chore: update CRD and related code to enable type field (ratify-pro…
0f94b25 
…ject#1779)

Co-authored-by: Binbin Li <[email protected]>
Signed-off-by: akashsinghal <[email protected]>
binbin-li added a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
@junczhu @binbin-li
chore: update CRD and related code to enable type field (ratify-pro…
4ef2e3b 
…ject#1779)

Co-authored-by: Binbin Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binbin-li binbin-li binbin-li approved these changes

@akashsinghal akashsinghal Awaiting requested review from akashsinghal akashsinghal is a code owner

@jimmyraywv jimmyraywv Awaiting requested review from jimmyraywv jimmyraywv is a code owner

@luisdlp luisdlp Awaiting requested review from luisdlp luisdlp is a code owner

@susanshi susanshi Awaiting requested review from susanshi susanshi is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch name field in CRDs to type
2 participants
@junczhu @binbin-li